ansys / pydpf-post

Data Processing Framework - Post Processing Module
https://post.docs.pyansys.com
MIT License
40 stars 8 forks source link

Clean init file #519

Closed PProfizi closed 8 months ago

PProfizi commented 8 months ago

Remove call to core.settings.set_dynamic_available_results_capability(False)

@cbellot000 do you remember why this was put there? It dates back to before the available GH/git history.

@FedericoNegri reported it being there and not necessarily being practical for the user in some situations.

codecov[bot] commented 8 months ago

Codecov Report

Merging #519 (49c8be4) into master (bb37a46) will decrease coverage by 0.06%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #519      +/-   ##
==========================================
- Coverage   83.83%   83.78%   -0.06%     
==========================================
  Files          47       47              
  Lines        5072     5068       -4     
==========================================
- Hits         4252     4246       -6     
- Misses        820      822       +2     
cbellot000 commented 8 months ago

Remove call to core.settings.set_dynamic_available_results_capability(False)

@cbellot000 do you remember why this was put there? It dates back to before the available GH/git history.

It's an API from pydpf-core? It would have been with the legacy API. But I'm intesrested to see where it's used in core?

PProfizi commented 8 months ago

Remove call to core.settings.set_dynamic_available_results_capability(False) @cbellot000 do you remember why this was put there? It dates back to before the available GH/git history.

It's an API from pydpf-core? It would have been with the legacy API. But I'm intesrested to see where it's used in core?

It is in ansys.dpf.core.settings, and it switches the variable misc.DYNAMIC_RESULTS which is used in Model.results here to force having only CommonResults.

It was dedicated to the legacy PyDPF-Post, but since it is in the init, it is the case also for the new Post API.