search

ansys / pydynamicreporting

Pyansys project for Ansys Dynamic Reporting, a report generator tool.
https://dynamicreporting.docs.pyansys.com/
MIT License
7 stars 1 forks source link

Fix/set filter method #80

Closed margalva closed 7 months ago

margalva commented 7 months ago

Fix a bug in template API: get_filter and set_filter was used both for high-level template method and for the filter value in the generator for table filter by value. Rename the methods, and leave set_filter as deprecated method for backward compatibility.

As we're at it, start migrating the lower level API documentation over pydynamicreporting docs.

codecov-commenter commented 7 months ago

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (231525f) 75.75% compared to head (95238ec) 75.64%.

Files Patch % Lines
...nsys/dynamicreporting/core/utils/report_objects.py 52.38% 9 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #80 +/- ## ========================================== - Coverage 75.75% 75.64% -0.11% ========================================== Files 16 16 Lines 4953 4972 +19 Branches 1048 1050 +2 ========================================== + Hits 3752 3761 +9 - Misses 851 860 +9 - Partials 350 351 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.