search

ansys / pyensight

Python API for EnSight
http://ensight.docs.pyansys.com
MIT License
6 stars 2 forks source link

Add Session API to check EnSight version #351

Closed randallfrank closed 9 months ago

randallfrank commented 9 months ago

Add a call on the Session object to make sure the EnSight version is at least some target.

codecov-commenter commented 9 months ago

Codecov Report

Attention: 255 lines in your changes are missing coverage. Please review.

Comparison is base (5dd10a3) 75.20% compared to head (c8841a2) 75.13%.

Files Patch % Lines
src/ansys/pyensight/core/utils/parts.py 26.13% 193 Missing and 2 partials :warning:
src/ansys/pyensight/core/utils/export.py 71.69% 51 Missing and 9 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #351 +/- ## ========================================== - Coverage 75.20% 75.13% -0.08% ========================================== Files 18 18 Lines 2860 2888 +28 Branches 518 526 +8 ========================================== + Hits 2151 2170 +19 - Misses 547 553 +6 - Partials 162 165 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

randallfrank commented 9 months ago

@randallfrank wonderful! Could you please add the same check with the same version on the create_particle/add_emitter/ functions in the parts utils?

Thanks!

@mariostieriansys I think I have this in now, please review.

mariostieriansys commented 9 months ago

@randallfrank thanks! That's perfect