ansys / pyfluent

Pythonic interface to Ansys Fluent
https://fluent.docs.pyansys.com
MIT License
282 stars 41 forks source link

cwd argument in launch_fluent gives uninteded warning #2633

Closed mkundu1 closed 7 months ago

mkundu1 commented 8 months ago
>>> solver = pyfluent.launch_fluent(cwd=r"d:\work")
pyfluent.launcher WARNING: These specified arguments are only supported when starting local standalone Fluent clients: cwd.
mkundu1 commented 7 months ago

@hpohekar Can you please look into this too as a part of the launcher code improvement? There might be more arguments for which such unexpected warnigns are coming. cc: @prmukherj @seanpearsonuk

hpohekar commented 7 months ago

Yes, sure.

hpohekar commented 7 months ago

@mkundu1

I'm not able to reproduce this issue in windows. i.e. standalone mode.

image

It raises warning only in Linux. i.e container mode

image

As per the code it is working fine because it should raise warning if we specify cwd to launch Fluent in other mode than standalone.

image

cc: @seanpearsonuk @prmukherj

hpohekar commented 7 months ago

@mkundu1 @seanpearsonuk

As we are specifying in above code that env, cwd, topy, case_file_name, lightweight_mode, journal_file_names, case_data_file_name are supported for Standalone mode only then should we remove them from constructor signature of PIM and Container launcher ?

hpohekar commented 7 months ago

Closing because not able to reproduce.

hpohekar commented 7 months ago

I'm getting this warning now.

image

hpohekar commented 7 months ago

@mkundu1 @seanpearsonuk

I think we have already removed arguments that are supported for Standalone mode only from constructors of PIM and Container launcher so maintaining this code and raising this warning is redundant.

I think we shall remove this code and warning.

Shall we remove this code now ?

hpohekar commented 7 months ago

I think if we use launch_fluent then this check will need there.

hpohekar commented 7 months ago

@mkundu1

I have tried to reproduce this issue on my and @prmukherj 's system (with latest changes) but it is not reproducible. Therefore closing this now. It's may be a random issue.