Open mkundu1 opened 3 days ago
We should put an updated design first before making any code change.
Please also consider consolidating the duplicate data api_tree_251.pickle
between api_tree/api_objects.json
. This will reduce out package size. The legacy _search
function can be removed if needed.
@seanpearsonuk @mkundu1
We can not remove _search
function for following reasons.
search_root
feature in search
.search_root
in search
then we get circular import error therefore as per our last discussion we have kept it separate in _search
only to be able to use it in flobject.py.We have kept api_tree_251.pickle
file as it is needed for _search
. To improve search performance we have added api_tree/api_objects.json
. I think we can have a single file to avoid duplication. Let's see.
Couple of proposed improvements for the search module from the chat: