ansys / pyfluent

Pythonic interface to Ansys Fluent
https://fluent.docs.pyansys.com
MIT License
280 stars 41 forks source link

Definition of direction specs for different BCs #3414

Open gantnera opened 1 month ago

gantnera commented 1 month ago

๐Ÿ” Before submitting the issue

๐Ÿž Description of the bug

I noticed that the direction specification command is depending on the specific boundary condition:

Example for Total Pressure Inlet: inBC = solver.setup.boundary_conditions.pressure_inlet["inlet"] inBC.momentum.direction_specification_method = 'Direction Vector'

Example Massflow Inlet: inBC = solver.setup.boundary_conditions.mass_flow_inlet["inlet"] inBC.momentum.direction_specification = 'Direction Vector'

One time its "direction_specification_method", the other time itยดs "direction_specification".

I didnยดt check the other BCs. Maybe the same issue occurs also for other BC properties, which should be checked here.

Could you please change this kind of BC-common commands to be consistent for all BCs?

๐Ÿ“ Steps to reproduce

see description

๐Ÿ’ป Which operating system are you using?

Windows

๐Ÿ“€ Which ANSYS version are you using?

v251

๐Ÿ Which Python version are you using?

3.10

๐Ÿ“ฆ Installed packages

about-time==4.2.1
alive-progress==3.1.5
ansys-api-fluent==0.3.28
ansys-api-platform-instancemanagement==1.1.0
ansys-api-tools-filetransfer==0.1.0
ansys-fluent-core==0.26.0
ansys-platform-instancemanagement==1.1.2
ansys-tools-filetransfer==0.1.0
ansys-units==0.3.2
beartype==0.19.0
certifi==2024.8.30
charset-normalizer==3.3.2
click==8.1.7
colorama==0.4.6
contourpy==1.3.0
cycler==0.12.1
docker==7.1.0
fonttools==4.54.1
grapheme==0.6.0
grpcio==1.66.2
grpcio-health-checking==1.62.3
idna==3.10
importlib_metadata==8.5.0
joblib==1.4.2
kiwisolver==1.4.7
lxml==5.3.0
matplotlib==3.9.2
nltk==3.9.1
numpy==1.26.4
packaging==24.1
pandas==2.2.3
pillow==10.4.0
platformdirs==4.3.6
protobuf==4.25.5
psutil==6.0.0
pyparsing==3.1.4
python-dateutil==2.9.0.post0
pytz==2024.2
pywin32==307
PyYAML==6.0.2
regex==2024.9.11
requests==2.32.3
six==1.16.0
tqdm==4.66.5
tzdata==2024.2
urllib3==2.2.3
zipp==3.20.2
prmukherj commented 1 day ago

For pressure-outlet, velocity-inlet, pressure-inlet and mass-flow-inlet: Image Image

There is some level of inconsistency in the naming and we need to decide a fix.