ansys / pyfluent

Pythonic interface to Ansys Fluent
https://fluent.docs.pyansys.com
MIT License
271 stars 40 forks source link

some optional dependencies are not real project dependencies #3420

Open seanpearsonuk opened 3 hours ago

seanpearsonuk commented 3 hours ago

Some of these are only used in documentation, not in library code:

openpyxl = { version = ">=3.1.5", optional = true } plotly = { version = ">=5.22.0", optional = true } python-pptx = { version = ">=0.6.23", optional = true } seaborn = { version = ">=0.13.2", optional = true } tensorflow = { version = ">=2.17.0", optional = true }

See pyproject.toml

hpohekar commented 3 hours ago

Some of these are only used in documentation, not in library code:

openpyxl = { version = ">=3.1.5", optional = true } plotly = { version = ">=5.22.0", optional = true } python-pptx = { version = ">=0.6.23", optional = true } seaborn = { version = ">=0.13.2", optional = true } tensorflow = { version = ">=2.17.0", optional = true }

See pyproject.toml

@seanpearsonuk These dependencies are required for example scripts therefore we have made them optional.

seanpearsonuk commented 3 hours ago

@hpohekar optional mitigates the issue but the dependendnecies are nevertheless in the wrong place. They should be expressed as documentation dependencies only.

hpohekar commented 3 hours ago

@seanpearsonuk We have already added them in [tool.poetry.extras]

hpohekar commented 3 hours ago

@hpohekar optional mitigates the issue but the dependendnecies are nevertheless in the wrong place. They should be expressed as documentation dependencies only.

OK.