Closed PipKat closed 6 months ago
Hi @PipKat, thanks for the review! Your changes all look good to me. If I get chance today I'll make the additional changes you requested, but I'll probably defer to @ludovicsteinbach, I think he's working a little bit next week,
@PipKat Thank you for reviewing the documentation.
I'll start by saying that this is heavily inspired (copied) from the pyansys meta-package repository.
serverapi-openapi
: it does not have documentation, because it is completely auto-generated and we don't recommend users use it directly. If it's adding confusion, perhaps we should remove it from the README?
include
directives with carefully defined references in the README to only pull relevant sections into the docs. Happy to use the new recommended approach of linking to the docs.@ludovicsteinbach or @PipKat I will let you merge this PR. Thanks for your work @PipKat .
@ludovicsteinbach I'll let you merge this PR when you are satisified with it. Thanks!
@MaxJPRey I put the review of the documentation for this smaller package before the review for SCADE API Tools
Here are the issues that I believe need to be addressed:
serverapi-openapi
package is missing from the files for each doc section.Note that I changed the labeling on the existing cards to match the PyGranta library names. (The don't have "MI" in them), and I also added a descriptor of what content they linked to. I had to reword the "User guide" section because the linked PyGranta documentation does not have "User guide" sections as was implied.
Given that we resolve the two issues I've described, I'm OK with this documentation.