ansys / pygranta

PyGranta metapackage
https://grantami.docs.pyansys.com/
MIT License
0 stars 0 forks source link

Doc review of PyGranta metapackage #13

Closed PipKat closed 6 months ago

PipKat commented 7 months ago

@MaxJPRey I put the review of the documentation for this smaller package before the review for SCADE API Tools

Here are the issues that I believe need to be addressed:

Note that I changed the labeling on the existing cards to match the PyGranta library names. (The don't have "MI" in them), and I also added a descriptor of what content they linked to. I had to reword the "User guide" section because the linked PyGranta documentation does not have "User guide" sections as was implied.

Given that we resolve the two issues I've described, I'm OK with this documentation.

Andy-Grigg commented 7 months ago

Hi @PipKat, thanks for the review! Your changes all look good to me. If I get chance today I'll make the additional changes you requested, but I'll probably defer to @ludovicsteinbach, I think he's working a little bit next week,

ludovicsteinbach commented 7 months ago

@PipKat Thank you for reviewing the documentation.

I'll start by saying that this is heavily inspired (copied) from the pyansys meta-package repository.

MaxJPRey commented 7 months ago

@ludovicsteinbach or @PipKat I will let you merge this PR. Thanks for your work @PipKat .

PipKat commented 6 months ago

@ludovicsteinbach I'll let you merge this PR when you are satisified with it. Thanks!