search

ansys / pymapdl-reader

Legacy binary interface to MAPDL binary files.
https://reader.docs.pyansys.com
MIT License
47 stars 23 forks source link

decouple the testing requirements of ansys-mapdl-core #100

Open jgd10 opened 2 years ago

jgd10 commented 2 years ago

The test suite relies on the installation of ansys-mapdl-core to operate properly. However, this also relies on an installation of this package, which results in a circular requirement and you end up installing the latest version of the package into your venv alongside the development version which is a recipe for confusion.

We should decouple these as suggested by Alex in https://github.com/pyansys/pymapdl-reader/pull/99

"by caching the expected results to *.npy arrays within testfiles."

jgd10 commented 2 years ago

At the moment tests won't run in PyCharm "Out of the box". And if you run pytest itself within the tests folder, it uses the installed version and not the development version.

jgd10 commented 2 years ago

So, the solution to this was to install in development mode and use Python 3.8 (3.9 didn't work). I have summarised the steps I took and added them to the README on the project. This was merged in in PR #103. The tests are still coupled, but the original problem is gone. This ticket should remain open, but is of lower priority now.