ansys / pymapdl

Pythonic interface to MAPDL
https://mapdl.docs.pyansys.com
MIT License
419 stars 116 forks source link

Possible improvements that could be made to pymapdl #2137

Open germa89 opened 1 year ago

germa89 commented 1 year ago

@germa89 @mikerife This issue suggests possible improvements that could be made to pymapdl:

def _validate_solve(self):

activate nlgeom if contact is involved.

pass

- [ ] post-processing commands throw a helpful exception if there is no active result set loaded.
- [ ] ET commands can write a warning if elements are already defined with the given id

_Originally posted by @koubaa in https://github.com/ansys/pymapdl/discussions/2123#discussioncomment-6243821_

Further additions:
Also add:
- [x] `mapdl.port` https://github.com/ansys/pymapdl/pull/2246
- [x] `mapdl.exited` https://github.com/ansys/pymapdl/pull/2246
- [x] `mapdl.check_status` https://github.com/ansys/pymapdl/pull/2246
- [x] `mapdl.ip` https://github.com/ansys/pymapdl/pull/2246
- [ ] Avoid `mapdl.amesh` in `mapdl.aplot`. That is the reason it is so slow. 
germa89 commented 11 months ago

Also add:

mikerife commented 11 months ago

I really feel that the SOLVE command needs to be left alone:

1) MAPDL already has heurestics built in to set some solution settings based on model type and features. I don't know that PyMAPDL needs to add to these.

2) It's not always correct to turn on large deformation, even with models with contact. At the very least it's hard to show the benefit of large deformation if we can't turn it off!

koubaa commented 11 months ago

@mikerife what if it just printed out some suggestions, rather than throwing any error or changing the behavior of solve?

mikerife commented 11 months ago

Care should be used when looking at adding a warning to multiple ET commands using the same ET ID. Reusing ET IDs is standard procedure in one way load coupled multiphysics models. It can also be SOP when using the MESH200 elements. Maybe an option to turn on 'enhanced warnings' that would pick up this type of usage?

mikerife commented 11 months ago

@koubaa that a good idea (printing suggestions)!

germa89 commented 11 months ago
germa89 commented 11 months ago