Closed clatapie closed 3 months ago
Thanks for opening a Pull Request. If you want to perform a review write a comment saying:
@ansys-reviewer-bot review
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 84.17%. Comparing base (
7c1eb1e
) to head (7ada8b1
). Report is 3 commits behind head on main.
Is this still a draft? @clatapie
The changelog can be effective but I wanted to add some documentation about commit and branch name conventions. I also have planned to add the ansys/action
that checks those names as pyansys-geometry does.
I will resume it next week
As the Contributing section in the PyAnsys dev guide details the naming conventions, adding the action should be enough to ensure a consistent changelog section. Pinging @germa89 for visibility.
I realised that dependabot also has a prefix for the commits. You might need to adapt that one too.
I realised that dependabot also has a prefix for the commits. You might need to adapt that one too.
Good catch, thank you @germa89.
I modified the dependabot.yml
file as follow:
pip
package ecosystem: the prefix used is now build
as it concerns external dependencies.github-actions
package ecosystem: the prefix used is now ci
as it concerns CI configuration.Do we have to change dependabot branch names too?
So far the branch names are something like dependabot/github_actions/actions-0bd1363a87
(https://github.com/ansys/pymapdl/pull/3175).
Shall we check how to change those names? or maybe skip that workflow for dependabot PRs?
As the ansys/action
accepts dependabot/
as a branch name, there is no need to modify it.
Also, it seems that this name is not configurable.
Implementing release note in documentation, using
ansys/actions/changelogs
and https://github.com/ansys/pyansys-geometry/pull/1138.