search

ansys / pymapdl

Pythonic interface to MAPDL
https://mapdl.docs.pyansys.com
MIT License
424 stars 120 forks source link

Update ansys-dpf-core #3082

Open germa89 opened 4 months ago

germa89 commented 4 months ago

As the title.

ansys-reviewer-bot[bot] commented 4 months ago

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

germa89 commented 4 months ago

Just testing.

germa89 commented 4 months ago

Hopefully this has been addressed in the new version: https://github.com/ansys/pydpf-core/issues/1438

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.21%. Comparing base (587a0cb) to head (0bfc6b6). Report is 5 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3082 +/- ## ========================================== + Coverage 82.67% 84.21% +1.54% ========================================== Files 53 53 Lines 9625 9625 ========================================== + Hits 7957 8106 +149 + Misses 1668 1519 -149 ```
germa89 commented 4 months ago

Still broken. @PProfizi

PProfizi commented 4 months ago

Hi @germa89,

Looking at the error, it seems you get the error linked to the change in operator naming for NMISC and SMISC. I think you are already aware that sadly there was a breaking change on those. I just would like to understand why you would get this error here. What server version is this pipeline using? I see a Docker image for 22.2 being used, isn't that a bit old?

germa89 commented 4 months ago

Hi @germa89,

Looking at the error, it seems you get the error linked to the change in operator naming for NMISC and SMISC. I think you are already aware that sadly there was a breaking change on those. I just would like to understand why you would get this error here. What server version is this pipeline using? I see a Docker image for 22.2 being used, isn't that a bit old?

Hi @PProfizi

Yes, it is a bit old. But I didn't have the time to figure it out how to deploy a newer version of DPF in our CICD. I know the docker registry I'm using hasn't been updated in 2 years. I'm happy to get some guidance on how to use newer versions of DPF in our CICD.

PProfizi commented 3 months ago

Hi @germa89, Looking at the error, it seems you get the error linked to the change in operator naming for NMISC and SMISC. I think you are already aware that sadly there was a breaking change on those. I just would like to understand why you would get this error here. What server version is this pipeline using? I see a Docker image for 22.2 being used, isn't that a bit old?

Hi @PProfizi

Yes, it is a bit old. But I didn't have the time to figure it out how to deploy a newer version of DPF in our CICD. I know the docker registry I'm using hasn't been updated in 2 years. I'm happy to get some guidance on how to use newer versions of DPF in our CICD.

Hi @germa89, do you necessarily need to go through the Docker registry? We do have a GitHub action to install DPF, which you can see used here.

germa89 commented 3 months ago

Hi @germa89, Looking at the error, it seems you get the error linked to the change in operator naming for NMISC and SMISC. I think you are already aware that sadly there was a breaking change on those. I just would like to understand why you would get this error here. What server version is this pipeline using? I see a Docker image for 22.2 being used, isn't that a bit old?

Hi @PProfizi Yes, it is a bit old. But I didn't have the time to figure it out how to deploy a newer version of DPF in our CICD. I know the docker registry I'm using hasn't been updated in 2 years. I'm happy to get some guidance on how to use newer versions of DPF in our CICD.

Hi @germa89, do you necessarily need to go through the Docker registry? We do have a GitHub action to install DPF, which you can see used here.

I do not need to go through the docker route. However, any proposed solution should work on github runners outside Ansys network. Do the action works in that way?

PProfizi commented 3 months ago

Hi @germa89, Looking at the error, it seems you get the error linked to the change in operator naming for NMISC and SMISC. I think you are already aware that sadly there was a breaking change on those. I just would like to understand why you would get this error here. What server version is this pipeline using? I see a Docker image for 22.2 being used, isn't that a bit old?

Hi @PProfizi Yes, it is a bit old. But I didn't have the time to figure it out how to deploy a newer version of DPF in our CICD. I know the docker registry I'm using hasn't been updated in 2 years. I'm happy to get some guidance on how to use newer versions of DPF in our CICD.

Hi @germa89, do you necessarily need to go through the Docker registry? We do have a GitHub action to install DPF, which you can see used here.

I do not need to go through the docker route. However, any proposed solution should work on github runners outside Ansys network. Do the action works in that way?

Yes, we use it on GitHub runners outside of the Ansys network. It just needs access via a secret to a token to our DPF server repo.

germa89 commented 3 months ago

@PProfizi thank you a lot for this! I will start to work on this after next week.