search

ansys / pymapdl

Pythonic interface to MAPDL
https://mapdl.docs.pyansys.com
MIT License
424 stars 120 forks source link

Refactoring PyHPS implementation #3117

Closed germa89 closed 4 months ago

germa89 commented 4 months ago

Going for a class based approach to make the code more reusable.

Also easier to understand, modify and extend.

ansys-reviewer-bot[bot] commented 4 months ago

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 0.20833% with 479 lines in your changes are missing coverage. Please review.

Project coverage is 79.74%. Comparing base (f23da00) to head (afb3a68).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## feat/pyhps-support #3117 +/- ## ====================================================== - Coverage 81.91% 79.74% -2.17% ====================================================== Files 54 54 Lines 9858 10098 +240 ====================================================== - Hits 8075 8053 -22 - Misses 1783 2045 +262 ```
germa89 commented 4 months ago

@pyansys-ci-bot LGTM.