ansys / pymapdl

Pythonic interface to MAPDL
https://mapdl.docs.pyansys.com
MIT License
419 stars 117 forks source link

fix: update the general files to align with PyAnsys standards #3151

Closed Revathyvenugopal162 closed 1 month ago

Revathyvenugopal162 commented 1 month ago
ansys-reviewer-bot[bot] commented 1 month ago

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.15%. Comparing base (28b0b69) to head (66bd540).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3151 +/- ## ========================================== - Coverage 86.61% 84.15% -2.47% ========================================== Files 52 52 Lines 9528 9528 ========================================== - Hits 8253 8018 -235 - Misses 1275 1510 +235 ```
jorgepiloto commented 1 month ago

What about the minimum_requirements.txt file placed in the root of the project?

Revathyvenugopal162 commented 1 month ago

What about the minimum_requirements.txt file placed in the root of the project?

Yes, we need to change it. However, I believe they are currently uploading it as artifacts, so altering this process might require reworking the CI/CD pipeline and possibly some documentation. Therefore, I thought of opening another PR to address those issues, if that’s alright with you.

jorgepiloto commented 1 month ago

Related with #3113