ansys / pymapdl

Pythonic interface to MAPDL
https://mapdl.docs.pyansys.com
MIT License
419 stars 117 forks source link

fix: combine the `docker-compose` files #3169

Closed Revathyvenugopal162 closed 2 weeks ago

Revathyvenugopal162 commented 3 weeks ago

Description

This PR merges three separate Docker Compose files into a single Docker Compose file containing three distinct services: mapdl, dpf, and mapdl-local.

To start a specific service, use the following command:

docker-compose up -d <service_name>

For example, to start the mapdl service, run:

docker-compose up -d mapdl

This consolidation simplifies the management and orchestration of our Docker services, making it easier to start, stop, and manage the individual components as needed.

ansys-reviewer-bot[bot] commented 3 weeks ago

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 63.22%. Comparing base (7c1eb1e) to head (b679524). Report is 8 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3169 +/- ## =========================================== - Coverage 86.63% 63.22% -23.42% =========================================== Files 52 52 Lines 9550 9596 +46 =========================================== - Hits 8274 6067 -2207 - Misses 1276 3529 +2253 ```
germa89 commented 2 weeks ago

Hi @Revathyvenugopal162

Thank you a lot for this PR! You make thought and google a bit... it seems now docker-compose supports "profiles".

https://docs.docker.com/compose/profiles/?highlight=profile

I will take the freedom to modify your PR to adapt to those profiles.

Docker Documentation
Using profiles with Compose
Revathyvenugopal162 commented 2 weeks ago

Hi @Revathyvenugopal162

Thank you a lot for this PR! You make thought and google a bit... it seems now docker-compose supports "profiles".

https://docs.docker.com/compose/profiles/?highlight=profile

I will take the freedom to modify your PR to adapt to those profiles.

Docker DocumentationUsing profiles with Compose

sure, no problem

Docker Documentation
Using profiles with Compose
Revathyvenugopal162 commented 2 weeks ago

Thanks @germa89 , i will merge the PR if its ok (pinging @jorgepiloto ) once the workflow finishes.