feat: Detaching logging from main logic

germa89 commented 1 week ago

Description

Login should be handled separately, and having its own command line like docker login.

Issue linked

NA

Checklist

[ ] I have visited and read Develop PyMAPDL.
[ ] I have tested my changes locally
[ ] I have added necessary documentation or updated existing documentation.
[ ] I have followed the PyMAPDL coding style guidelines.
[ ] I have added appropriate unit tests that also ensure the minimal coverage criteria.
[ ] I have reviewed my changes before submitting this pull request.
[ ] I have linked the issue or issues that are solved to the PR if any.
[x] I have assigned this PR to myself.
[x] I have marked this PR as draft if it is not ready to be reviewed yet.
[x] I have made sure that the title of my PR follows Commit naming conventions (e.g. feat: adding new MAPDL command)

ansys-reviewer-bot[bot] commented 1 week ago

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

codecov[bot] commented 6 days ago

Codecov Report

Attention: Patch coverage is 2.72727% with 214 lines in your changes missing coverage. Please review.

Project coverage is 77.96%. Comparing base (dd0cb4b) to head (9818a16).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## feat/pyhps-support #3205 +/- ## ====================================================== - Coverage 79.82% 77.96% -1.86% ====================================================== Files 55 57 +2 Lines 10200 10406 +206 ====================================================== - Hits 8142 8113 -29 - Misses 2058 2293 +235 ```

ansys / pymapdl