ci: improving if to match also schedule and workflow_dispatch

germa89 commented 5 days ago

Description

The unit tests are not running currently because of the last reorg of the workflow steps done in https://github.com/ansys/pymapdl/pull/3171, because now they depends on the smoke tests which were not running previously on schedule or workflow dispatch.

Issue linked

NA

Checklist

[ ] I have visited and read Develop PyMAPDL.
[ ] I have tested my changes locally
[ ] I have added necessary documentation or updated existing documentation.
[ ] I have followed the PyMAPDL coding style guidelines.
[x] I have added appropriate unit tests that also ensure the minimal coverage criteria.
[x] I have reviewed my changes before submitting this pull request.
[x] I have linked the issue or issues that are solved to the PR if any.
[x] I have assigned this PR to myself.
[x] I have marked this PR as draft if it is not ready to be reviewed yet.
[x] I have made sure that the title of my PR follows Commit naming conventions (e.g. feat: adding new MAPDL command)

ansys-reviewer-bot[bot] commented 5 days ago

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

codecov[bot] commented 5 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 63.02%. Comparing base (7c1eb1e) to head (091e807). Report is 28 commits behind head on main.

:exclamation: There is a different number of reports uploaded between BASE (7c1eb1e) and HEAD (091e807). Click for more details.

HEAD has 267 uploads less than BASE
| Flag | BASE (7c1eb1e) | HEAD (091e807) | |------|------|------| |v23.2-ubuntu|12|0| |minimal|20|2| |ubuntu|40|2| |local|40|2| |v24.1-ubuntu-student|12|1| |latest-ubuntu-student|12|1| |latest-ubuntu|12|0| |v24.1-ubuntu|11|0| |centos|45|0| |remote|45|0| |v23.1-ubuntu|4|0| |v22.2.1|4|0| |v22.2-ubuntu|3|0| |v23.2.0|4|0| |v24.2.0|4|0| |v24.1.0|4|0| |v23.1.0|3|0|

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #3223 +/- ## =========================================== - Coverage 86.63% 63.02% -23.62% =========================================== Files 52 53 +1 Lines 9550 9625 +75 =========================================== - Hits 8274 6066 -2208 - Misses 1276 3559 +2283 ```

germa89 commented 5 days ago

Tested on workflow-dispatch on here: https://github.com/ansys/pymapdl/actions/runs/9693282743

GitHub
CI · ansys/pymapdl@c00d094
Pythonic interface to MAPDL. Contribute to ansys/pymapdl development by creating an account on GitHub.

clatapie commented 4 days ago

I didn't mean to retest the changes as they will not be tested. I tried to cancel it but it was too late. Sorry about it!

ansys / pymapdl