ansys / pysherlock

Pythonic interface to Sherlock
https://sherlock.docs.pyansys.com
MIT License
7 stars 0 forks source link

fix: allow newer protobuf versions #371

Closed RobPasMue closed 2 weeks ago

RobPasMue commented 2 weeks ago

@ansnfernand - would it be possible to do a new patch release (0.7.1) once this PR is merged? Even though you made the protobuf version more flexible in the API package, it is also required to make it more flexible on this repo.

Checklist:

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 56.77%. Comparing base (a5f056e) to head (2a9c25b). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #371 +/- ## ======================================= Coverage 56.77% 56.77% ======================================= Files 21 21 Lines 4541 4541 ======================================= Hits 2578 2578 Misses 1963 1963 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

RobPasMue commented 2 weeks ago

@ansjmoody @ansnfernand @ansnraines - can we get this merged and released in a new version? This is related to https://github.com/ansys/ansys-tools-protoc-helper/issues/29

jmoody commented 2 weeks ago

I think you meant to mention someone else.

RobPasMue commented 2 weeks ago

I think you meant to mention someone else.

Sorry about that!

RobPasMue commented 2 weeks ago

@ansnfernand - could we get a new release whenever you can? =) thanks a lot!

ansnfernand commented 2 weeks ago

@RobPasMue Done :D

RobPasMue commented 2 weeks ago

Thanks a lot @ansnfernand! Really appreciated =)