Fix/read write modes - Githubissues

ansys / pytwin

Ansys Digital Twin repository

https://twin.docs.pyansys.com

MIT License

19 stars 7 forks source link

Fix/read write modes #122

Closed chrpetre closed 1 year ago

chrpetre commented 1 year ago

this PR implements changes to use numpy for

read/write binary files (snapshots, svd basis,...)
read settings file and associated named selection ids
modify the examples to show more performant code for reading binary files @EDCarman FYI

codecov-commenter commented 1 year ago

Codecov Report

Merging #122 (2b90db9) into main (4897685) will decrease coverage by 0.06%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #122      +/-   ##
==========================================
- Coverage   88.86%   88.80%   -0.06%     
==========================================
  Files          11       11              
  Lines        2334     2322      -12     
==========================================
- Hits         2074     2062      -12     
  Misses        260      260

chrpetre commented 1 year ago

thanks for the detailed review @EDCarman, these should be addressed