feat: update linting tools - Githubissues

ansys / pyworkbench

PyWorkbench

http://workbench.docs.pyansys.com/

MIT License

3 stars 4 forks source link

feat: update linting tools #51

Closed jorgepiloto closed 6 months ago

jorgepiloto commented 7 months ago

Partially address issue #50 by enhancing pre-commit with:

The ansys-pre-commit hooks
Use Ruff as the main linting and formatting tool

Commits include:

Pre-commit and Ruff config in https://github.com/ansys-internal/pyworkbench/pull/51/commits/98b6eb80a49770f3eb1b0cce10b5683d7d6bf3e4
License headers added in https://github.com/ansys-internal/pyworkbench/pull/51/commits/b3336401ed06c9bffb4b589e9c4402d90ba857e8

jorgepiloto commented 7 months ago

@franknli, some issues need to be addressed, see https://github.com/ansys-internal/pyworkbench/actions/runs/8596236806/job/23552422952?pr=51#step:2:274

Revathyvenugopal162 commented 6 months ago

updated the code style fix and disable the "PTH" check which will check for https://docs.astral.sh/ruff/rules/#flake8-use-pathlib-pth pathlib instead of os.

jorgepiloto commented 6 months ago

That's correct @franknli. We can merge this, restore some of the linting tools later, and keep working on #50.