search

ansys / pyworkbench

PyWorkbench
http://workbench.docs.pyansys.com/
MIT License
3 stars 4 forks source link

MAINT: Update protobuf requirement from <3.21.0,>=3.19.6 to >=3.19.6,<4.25.0 #8

Closed dependabot[bot] closed 6 months ago

dependabot[bot] commented 1 year ago

Updates the requirements on protobuf to permit the latest version.

Commits
  • ee13554 Updating version.json and repo version numbers to: 24.3
  • a19e9ab Merge pull request #13881 from honglooker/24.x
  • 6af84ee bring protobuf dep [upb] to parity for 24.3
  • 3465661 Silence warnings about extra semicolon in non-TSAN builds. (#13820)
  • 398a84c Workaround ICE on gcc 7.5 by not having one overload call the other one with ...
  • e5b5696 Merge pull request #13697 from protocolbuffers/24.x-202308252017
  • afecb47 Updating version.json to: 24.3-dev
  • 54a2e5c Updating version.json and repo version numbers to: 24.2
  • 7b825e1 Merge pull request #13656 from protocolbuffers/backport-tdp-msvc-32
  • 5626baf Remove a flaky test with very high memory requirements.
  • Additional commits viewable in compare view


You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Revathyvenugopal162 commented 6 months ago

We don't need this change now - another pull request is removing this dependency.

Since you dont need this change, we can close this PR?

franknli commented 6 months ago

We don't need this change now - another pull request is removing this dependency.

Since you dont need this change, we can close this PR?

@Revathyvenugopal162 Google ProtoBuf is used by ansys-api-workbench package, which pyworkbench depends on. So I guess we don't need to specify indirect dependencies here, correct? Then we can remove this dependency totally.

Revathyvenugopal162 commented 6 months ago

We don't need this change now - another pull request is removing this dependency.

Since you dont need this change, we can close this PR?

@Revathyvenugopal162 Google ProtoBuf is used by ansys-api-workbench package, which pyworkbench depends on. So I guess we don't need to specify indirect dependencies here, correct? Then we can remove this dependency totally.

yes, we can remove.

franknli commented 6 months ago

We don't need this change now - another pull request is removing this dependency.

Since you dont need this change, we can close this PR?

@Revathyvenugopal162 Google ProtoBuf is used by ansys-api-workbench package, which pyworkbench depends on. So I guess we don't need to specify indirect dependencies here, correct? Then we can remove this dependency totally.

yes, we can remove.

I just checked - and it is already removed in main. So go ahead and close this PR. Thanks!

dependabot[bot] commented 6 months ago

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.