search

ant-design / ant-design-icons

⭐ Ant Design SVG Icons
https://ant.design/components/icon/
MIT License
952 stars 581 forks source link

CSP: Remove @babel/runtime from dependencies #491

Open deleonio opened 3 years ago

deleonio commented 3 years ago

@babel/runtime contains a dependency regenenerator-runtime. And this break the Content-Security-Policy unsafe-eval.

I think, that @babel/runtime should not be a part of dependency. It must be a part of devDependency?!

deleonio commented 3 years ago

Read that: @tellnes

No issue tab?! - https://github.com/ant-design/react-slick

tellnes commented 3 years ago

Read that: @tellnes

No issue tab?! - https://github.com/ant-design/react-slick

?

deleonio commented 3 years ago

@tellnes : at the repo - there is no active isssue tab. Please logout and try it.

We have CSP errors and we should remove the unsafe-eval.

tellnes commented 3 years ago

Yes, but why do you mention me? I'm not a maintainer, just a random contributor sending the latest PR that got merged to @ant-design/react-slick.

deleonio commented 3 years ago

Fix it with your bundler: https://leanupjs.org/1.2/guide/migration/#if-you-have-unsafe-eval-with-babel-runtime

deleonio commented 3 years ago

@yoyo837 - Please check this issue.

nicolo-ribaudo commented 2 years ago

Hi! This issue can probably be closed; @babel/runtime@7.18.0 does not depend on regenerator-runtime anymore.