search

ant-design / ant-design-icons

⭐ Ant Design SVG Icons
https://ant.design/components/icon/
MIT License
940 stars 577 forks source link

Angular 16 support #564

Closed jornare closed 1 year ago

jornare commented 1 year ago

icons-angular updated to version 16. Builds with Angular 16, and with updated dependencies.

Nicoss54 commented 1 year ago

Hi now with angular 16, we can pass some meta to say that the input is required or not, I think it could be a good idea to use this feature in the directive to make the input type required.

What do you think of that ?

jornare commented 1 year ago

Hi now with angular 16, we can pass some meta to say that the input is required or not, I think it could be a good idea to use this feature in the directive to make the input type required.

What do you think of that ?

Absolutely. However, I would really like to see the 16 support asap, then extend with this feature in a separate pr. I guess it could cause breaking changes for some..? There could also be other refactoring issues we could update here (Skip module?), but I don't have the time nor insight at the moment to take that into consideration.

Nicoss54 commented 1 year ago

Hi now with angular 16, we can pass some meta to say that the input is required or not, I think it could be a good idea to use this feature in the directive to make the input type required. What do you think of that ?

Absolutely. However, I would really like to see the 16 support asap, then extend with this feature in a separate pr.

Okkey thanks for the work and answer :)

jornare commented 1 year ago

Seems like the CI needs a docker/node version update.

wzhudev commented 1 year ago

I will fix the CI issue in another PR.