ant-design / ant-design-icons

⭐ Ant Design SVG Icons
https://ant.design/components/icon/
MIT License
940 stars 577 forks source link

5.1.1 版本构建出的 UMD 模块报错,找不到 React #574

Closed ShenHongFei closed 1 year ago

ShenHongFei commented 1 year ago

5.1.0 正常 升级到 5.1.1 之后出现

Uncaught TypeError: Cannot read properties of undefined (reading 'createContext') at icons.min.js:1:695124 at icons.min.js:1:795911 at icons.min.js:1:795916 at icons.min.js:1:247 at icons.min.js:1:329

image

可能的原因是 window 上取不到 window.React 属性,应该直接取 React 属性 image

zombieJ commented 1 year ago

搞个重现看看?我 Debug 一下~

zombieJ commented 1 year ago

https://github.com/ant-design/ant-design-icons/pull/573/files#diff-c57dba5b5e9d091e853c615d28ab7e34c12efc1302a862cf6ecbd22d8fb75a10R10 @PeachScript 看一下是不是配置不兼容

PeachScript commented 1 year ago

https://github.com/ant-design/ant-design-icons/pull/573/files#diff-c57dba5b5e9d091e853c615d28ab7e34c12efc1302a862cf6ecbd22d8fb75a10R10 @PeachScript 看一下是不是配置不兼容

应该是的,externals 配置需要省略 window,旧版基于 Rollup,新版基于 Webpack

afc163 commented 1 year ago

Fixed in https://github.com/ant-design/ant-design-icons/commit/49a8c618c3bed3d85115f3eafe349e74ca984bf0

afc163 commented 1 year ago

@zombieJ 请发 PR

ShenHongFei commented 1 year ago

5.1.2 版本修复了找不到 React 的报错,但还是没有 icons 全局变量,似乎所有的导出都放到了 window 上

image

webpack 中 externals 配置如下

image

@PeachScript @afc163

afc163 commented 4 months ago

这个问题疑似还在。

PeachScript commented 4 months ago

这个问题疑似还在。

问题有复现吗