search

ant-design / ant-design-icons

⭐ Ant Design SVG Icons
https://ant.design/components/icon/
MIT License
939 stars 577 forks source link

Warning: Invalid DOM property `fill-rule`. Did you mean `fillRule`? #603

Open sabreu-teknorix opened 9 months ago

sabreu-teknorix commented 9 months ago

I am getting this warning in the console image

localpath commented 8 months ago

@sabreu-teknorix submitted a PR against this invalid prop

linround commented 6 months ago

When will it be fixed?

vryzhova commented 4 months ago

@localpath Will it be fixed in version "@ant-design/icons": "4.0.0"?) And when?)

RobbertWolfs commented 4 months ago

its also on other icons..

image
afc163 commented 4 months ago

@RobbertWolfs Could you provide a codesandbox reproduce?

localpath commented 4 months ago

@afc163 I opened a PR already for this fix. You can see here the SVG is incorrectly implemented not using JSX prop syntax, rather a mix of JSX and HTML syntax

https://github.com/ant-design/ant-design-icons/pull/604/files#diff-0fc7bc4d89c25c35eb2e9992006a736c290c47643fca45f5153c057778986c27

afc163 commented 4 months ago

@localpath Could you provide a codesandbox reproduce?

RobbertWolfs commented 4 months ago

@afc163 As you can see we just have a basic react + vite setup with ant design installed and when you open the console you see the same issue

https://codesandbox.io/p/devbox/fervent-minsky-skhhlk

image

And as you can see its on multiple icons

image