fix: children as react element in tabs

ant-design / ant-design-mobile-rn

Ant Design for React Native

https://rn.mobile.ant.design/

MIT License

3k stars 610 forks source link

fix: children as react element in tabs #1266

Closed Kirbo closed 1 year ago

Kirbo commented 1 year ago

This PR adds the ability to pass a React element into the Tabs element. For example :

<Tabs>
  <View>
    <Text>Content of Third Tab</Text>
  </View>
</Tabs>

floatplane commented 1 year ago

@1uokun could you spend some time fixing this problem for all components that accept children?

https://github.com/ant-design/ant-design-mobile-rn/pull/1257 was a similar PR, but only fixed 3 components
I've noticed that TabBar still needs to have children added to its type declaration

1uokun commented 1 year ago

@1uokun could you spend some time fixing this problem for all components that accept children?

fix: type error on React 18 #1257 was a similar PR, but only fixed 3 components

I've noticed that TabBar still needs to have children added to its type declaration

fixed: https://github.com/ant-design/ant-design-mobile-rn/commit/0d08b6bfe90f923f14155734979e551815ee9b0b