search

ant-design / ant-design-mobile

Essential UI blocks for building mobile web apps.
https://mobile.ant.design
MIT License
11.62k stars 2.39k forks source link

feat: add toggle callback to Ellipsis component #6576

Closed damonyoungcc closed 6 months ago

damonyoungcc commented 6 months ago

close https://github.com/ant-design/ant-design-mobile/issues/6570

github-actions[bot] commented 6 months ago

PR preview has been successfully built and deployed to https://antd-mobile-preview-pr-6576.surge.sh

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.34%. Comparing base (937f845) to head (04d4353).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #6576 +/- ## ======================================= Coverage 92.34% 92.34% ======================================= Files 318 318 Lines 6910 6912 +2 Branches 1729 1731 +2 ======================================= + Hits 6381 6383 +2 Misses 493 493 Partials 36 36 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

damonyoungcc commented 6 months ago

这里我只是先发出来讨论一下，感觉用toggle这个名字不太好

  1. 或者加上受控的方案，用onChange
  2. 或者参考arco，增加onEllipsisNodeClick 和 onCollapseNodeClick
zombieJ commented 6 months ago

Why close?

zombieJ commented 6 months ago

Why close?