douxc commented 3 years ago

当前的isUrl判断里只有网络图片才支持，添加一个新的判断，如果icon配置是一个图片也允许直接展示

chenshuai2144 commented 3 years ago

抽一下 isimg好了

codecov-commenter commented 3 years ago

Codecov Report

Merging #585 into master will decrease coverage by 0.02%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #585      +/-   ##
==========================================
- Coverage   65.22%   65.20%   -0.03%     
==========================================
  Files          34       34              
  Lines        1090     1092       +2     
  Branches      413      413              
==========================================
+ Hits          711      712       +1     
- Misses        376      377       +1     
  Partials        3        3

Impacted Files	Coverage Δ
src/SiderMenu/BaseMenu.tsx	`72.95% <0.00%> (+0.62%)`	:arrow_up:
src/utils/utils.ts	`37.34% <0.00%> (-0.93%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d3cd549...112d33f. Read the comment docs.

joesdu commented 3 years ago

你这个正则没办法判断是否是本地图吧.虽然这两种链接用法没啥问题

douxc commented 3 years ago

你这个正则没办法判断是否是本地图吧.虽然这两种链接用法没啥问题

这边并不是判断是不是本地图片，只是判断了如果是个链接或者图片，就直接展示，否则会使用icon的方式处理

ant-design / ant-design-pro-layout

icon支持本地图片 #585

Codecov Report