ant-design / ant-design-pro-layout

🌃 Powerful and easy to use beautiful layout
https://prolayout.ant.design/
MIT License
1k stars 239 forks source link

feat: 增加 header 高度自定义 API #590

Closed WynterDing closed 3 years ago

WynterDing commented 3 years ago

支持自定义header 高度

headerHeight: 64

发现很多写死的48px 不知道会不会有一些没考虑到的

@chenshuai2144 帮看下

codecov-commenter commented 3 years ago

Codecov Report

Merging #590 into master will increase coverage by 0.03%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #590      +/-   ##
==========================================
+ Coverage   65.20%   65.23%   +0.03%     
==========================================
  Files          34       34              
  Lines        1092     1093       +1     
  Branches      413      414       +1     
==========================================
+ Hits          712      713       +1     
  Misses        377      377              
  Partials        3        3              
Impacted Files Coverage Δ
src/GlobalHeader/index.tsx 42.85% <ø> (ø)
src/Header.tsx 89.28% <ø> (ø)
src/SiderMenu/index.tsx 69.23% <ø> (ø)
src/defaultSettings.ts 100.00% <ø> (ø)
src/SiderMenu/SiderMenu.tsx 83.33% <100.00%> (+0.25%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 28fa344...f5a1510. Read the comment docs.

WynterDing commented 3 years ago

本来想做个 colorSideBg, 给有颜色的一侧增加颜色配置,但是感觉这是个伪需求。

如果有这种需求,这么折腾还不如直接手写样式覆盖