ant-design / ant-design-web3

🥳 Efficient react components for building dapps easier | Connect crypto wallets and more Web3 UI components | Web3 icons | Supports Ethereum, Solana, Bitcoin and others.
https://web3.ant.design
MIT License
768 stars 116 forks source link

Address display type should be checksum not only lowercase #373

Open lxhyl opened 6 months ago

lxhyl commented 6 months ago

Generally checksum is use to display Ethereum address in dApp. Like most popular dApp like UniSwap, Balancer, GMX...

There have a article to explain why Checksum is necessary.

https://medium.com/coinmonks/ethereum-checksummed-addresses-importance-and-implementation-eef74aa3ae18

yutingzhao1991 commented 6 months ago

Good suggestion, how about add a new prop `checksum` for it?

When checksum is true, check address and show error when address is not correct.

lxhyl commented 6 months ago

Cool. And i'm happy to do this if you don't have the time

yutingzhao1991 commented 6 months ago

Cool. And i'm happy to do this if you don't have the time

Of course, you're welcome, but how to reflect the situation of an incorrect address in terms of style may require design support, which we can discuss further.