search

ant-design / ant-design

An enterprise-class UI design language and React UI library
https://ant.design
MIT License
91.94k stars 48.99k forks source link

Modal 下 destroyOnClose 属性 失效 #28847

Open wansuiasdn opened 3 years ago

wansuiasdn commented 3 years ago

Reproduction link

https://fvrw0.csb.app/

Steps to reproduce

modal下使用video标签，播放后，关闭modal video or audio标签依然播放， 且重新打开modal 依然存在

What is expected?

modal关闭后销毁媒体标签

What is actually happening?

modal关闭后未销毁标签

Environment Info
antd 4.10.2
React 16.12.0
System win10
Browser firefox
ant-design-bot commented 3 years ago

Hello @wansuiasdn. Please provide a online reproduction by forking this link https://u.ant.design/codesandbox-repro or a minimal GitHub repository. Issues labeled by Need Reproduce will be closed if no activities in 3 days.

你好 @wansuiasdn, 我们需要你提供一个在线的重现实例以便于我们帮你排查问题。你可以通过点击 此处 创建一个 codesandbox 或者提供一个最小化的 GitHub 仓库。3 天内未跟进此 issue 将会被自动关闭。

wansuiasdn commented 3 years ago

Hello @wansuiasdn. Please provide a online reproduction by forking this link https://u.ant.design/codesandbox-repro or a minimal GitHub repository. Issues labeled by Need Reproduce will be closed if no activities in 3 days.

你好 @wansuiasdn, 我们需要你提供一个在线的重现实例以便于我们帮你排查问题。你可以通过点击 此处 创建一个 codesandbox 或者提供一个最小化的 GitHub 仓库。3 天内未跟进此 issue 将会被自动关闭。

https://fvrw0.csb.app/

afc163 commented 3 years ago

forceRender 和 destroyOnClose 一起开启时，destroyOnClose 貌似失效了。

ant-design-bot commented 3 years ago

Hello @wansuiasdn. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch (feature branch for the new feature, master for bugfix and other changes), fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. We appreciate your effort in advance and looking forward to your contribution!

你好 @wansuiasdn，我们完全同意你的提议/反馈，欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支（新特性发到 feature 分支，其他发到 master 分支），务必填写 Pull Request 内的预设模板，提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等，并确保 CI 通过，我们会尽快进行 Review，提前感谢和期待您的贡献。

giphy

monolithed commented 12 months ago

I confirm that destroyOnClose doesn't work. As a workaround, I've tried using getContainer and forceRender, but it didn't help. The component's state persists after closing. I don't understand how people have been living with this for two years.