ant-design / ant-design

An enterprise-class UI design language and React UI library
https://ant.design
MIT License
92.43k stars 49.7k forks source link

Tree data table checkboxes do not have aria-label attributes #32118

Open kpustakhod opened 3 years ago

kpustakhod commented 3 years ago

Reproduction link

https://ant.design/components/table/#components-table-demo-tree-data

Steps to reproduce

go to https://ant.design/components/table/#components-table-demo-tree-data, turn on voiceover, navigate with TAB key through tree table.

What is expected?

All checkboxes should have self explained aria-label attributes.

What is actually happening?

Voiceover reads this checkboxes as 'unchecked, checkbox' or 'checked, checkbox' without explanation.

Environment Info
antd 4.16.13
React 17.0.0
System Mac
Browser Chrome
github-actions[bot] commented 3 years ago

Hello @kpustakhod. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch (feature branch for the new feature, master for bugfix and other changes), fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. We appreciate your effort in advance and looking forward to your contribution!

你好 @kpustakhod,我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支(新特性发到 feature 分支,其他发到 master 分支),务必填写 Pull Request 内的预设模板,提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献。

giphy

joeheyming commented 3 years ago

it seems the issue might be upstream in the tree-select library.

mellis481 commented 1 year ago

@kpustakhod Should this issue be logged in rc-tree-select instead?

kpustakhod commented 1 year ago

@joeheyming , @mellis481 this issue is about meaningful aria-label for checkboxes that are used for row selection in table. I don't see that table checkboxes are part of rc-tree-select and believe that this is a part of antD functionality - https://github.com/ant-design/ant-design/blob/master/components/table/hooks/useSelection.tsx#L519