Closed jmatelowski closed 2 years ago
Hello @jmatelowski. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch (feature branch for the new feature, master for bugfix and other changes), fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. We appreciate your effort in advance and looking forward to your contribution!
你好 @jmatelowski,我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支(新特性发到 feature 分支,其他发到 master 分支),务必填写 Pull Request 内的预设模板,提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献。
May i work on it?
@kiner-tang your change introduced this bug https://github.com/ant-design/ant-design/issues/39410 so if you can kindly please test your changes in a screen reader (like NVDA, VoiceOver, etc) that would help prevent regressions for non-visual users.
cc @mellis481
Reproduction link
Steps to reproduce
name
column already changed)th
aria-label
propWhat is expected?
aria-label="name sortable"
What is actually happening?
aria-label="[object Object] sortable"
Table columns documentation says that
column.title
supportsReactNode
but unfortunatelly, if we provide theReactNode
instead ofstring
thearia-label
value is broken. It impede to table header cell accessibility. For example: it is difficult to get element by role in React Testing Library.Added in https://github.com/ant-design/ant-design/pull/37167