ant-design / ant-design

An enterprise-class UI design language and React UI library
https://ant.design
MIT License
90.42k stars 46.41k forks source link

fix(step): custom icon not vertically centered error #48650

Closed ZinkWu closed 2 weeks ago

ZinkWu commented 2 weeks ago

…t the default size of Steps

中文版模板 / Chinese template

🤔 This is a ...

🔗 Related issue link

fix #48641

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix <Step /> custom icon not vertically centered errorr
🇨🇳 Chinese 修复 <Steps /> 自定义图标未垂直居中问题

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

stackblitz[bot] commented 2 weeks ago

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

github-actions[bot] commented 2 weeks ago

Preview is ready

github-actions[bot] commented 2 weeks ago

👁 Visual Regression Report for PR #48650 Failed ❌

🎯 Target branch: master (bf330cbedbdc995e045953a3c13fa14915e8594b) 📖 View Full Report ↗︎

Expected (Branch master) Actual (Current PR) Diff
steps-component-token.compact.png steps-component-token.compact.png steps-component-token.compact.png steps-component-token.compact.png
steps-component-token.compact.png steps-component-token.compact.png steps-component-token.compact.css-var.png steps-component-token.compact.css-var.png
steps-component-token.dark.png steps-component-token.dark.png steps-component-token.dark.png steps-component-token.dark.png
steps-component-token.dark.png steps-component-token.dark.png steps-component-token.dark.css-var.png steps-component-token.dark.css-var.png
steps-component-token.default.png steps-component-token.default.png steps-component-token.default.png steps-component-token.default.png
steps-component-token.default.png steps-component-token.default.png steps-component-token.default.css-var.png steps-component-token.default.css-var.png

Check Full Report for details

codesandbox-ci[bot] commented 2 weeks ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Wxh16144 commented 2 weeks ago

标题太长了点.

pr 描述用 fix #48641 关联一下

另外 commitmsg 里面加一个


Co-authored-by: nova1751 <nova1751@users.noreply.github.com>
ZinkWu commented 2 weeks ago

标题太长了点.

pr 描述用 fix #48641 关联一下

另外 commitmsg 里面加一个


Co-authored-by: nova1751 <nova1751@users.noreply.github.com>

这里需要先 revert 之前的 commit 重新提交还是直接push一个新的commit呢?

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (9d4a532) to head (5469823). Report is 3 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #48650 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 745 745 Lines 12946 12946 Branches 3382 3382 ========================================= Hits 12946 12946 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 2 weeks ago

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。