ant-design / ant-design

An enterprise-class UI design language and React UI library
https://ant.design
MIT License
90.42k stars 46.41k forks source link

fix(Transfer): fix transfer issue when trying to select item from the… #48664

Closed andreyk1512 closed 2 weeks ago

andreyk1512 commented 2 weeks ago

… right column while it has "unknown-key" within targetKeys

中文版模板 / Chinese template

🤔 This is a ...

🔗 Related issue link

fix #48663

💡 Background and solution

Transfer component crashes the app when trying to select item from the right column while it has "unknown-key" within targetKeys.

To solve this I've added optional chaining when check 'disabled' property in 'item' object. It should help to filter empty items and avoid the issue.

📝 Changelog

Language Changelog
🇺🇸 English Fix Transfer component issue when trying to select item from the right column while it has "unknown-key" within targetKeys
🇨🇳 Chinese

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

stackblitz[bot] commented 2 weeks ago

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

github-actions[bot] commented 2 weeks ago

Preview is ready

github-actions[bot] commented 2 weeks ago

👁 Visual Regression Report for PR #48664 Passed ✅

🎯 Target branch: master (c8bd145ab4ca0c5b234be327b7f793137cf293d7) 📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

codesandbox-ci[bot] commented 2 weeks ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

github-actions[bot] commented 2 weeks ago

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

Wxh16144 commented 2 weeks ago

The changelog ci check failed, and the test case is missing. 😅