Add missing translation for id and jp

ant-design / ant-design

An enterprise-class UI design language and React UI library

https://ant.design

MIT License

90.42k stars 46.41k forks source link

Add missing translation for id and jp #48690

Closed edikurniawan-dev closed 2 weeks ago

edikurniawan-dev commented 2 weeks ago

中文版模板 / Chinese template

🤔 This is a ...

[ ] New feature
[ ] Bug fix
[ ] Site / documentation update
[ ] Demo update
[ ] Component style update
[ ] TypeScript definition update
[ ] Bundle size optimization
[ ] Performance optimization
[ ] Enhancement feature
[x] Internationalization
[ ] Refactoring
[ ] Code style optimization
[ ] Test Case
[ ] Branch merge
[ ] Workflow
[ ] Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language	Changelog
🇺🇸 English	--
🇨🇳 Chinese	--

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

[ ] Doc is updated/provided or not needed
[ ] Demo is updated/provided or not needed
[ ] TypeScript definition is updated/provided or not needed
[ ] Changelog is provided or not needed

stackblitz[bot] commented 2 weeks ago

Run & review this pull request in StackBlitz Codeflow.

github-actions[bot] commented 2 weeks ago

👁 Visual-Regression Diff Building... ⏳

This PR is under visual-regression-diff building, please wait for the result.

yoyo837 commented 2 weeks ago

So, is this overturning the previous PR #48287 ?

codesandbox-ci[bot] commented 2 weeks ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

edikurniawan-dev commented 2 weeks ago

So, is this overturning the previous PR #48287 ?

Yes, because many user say it's better like the original, namely 'OK'. So the snapshot will be as before

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (ce43007) to head (0609f68).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #48690 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 745 745 Lines 12947 12947 Branches 3383 3383 ========================================= Hits 12947 12947 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

yoyo837 commented 2 weeks ago

Personally, it is better to split it into two PRs.

edikurniawan-dev commented 2 weeks ago

What do you mean, Indonesian and Japanese PR are separated?

yoyo837 commented 2 weeks ago

What do you mean, Indonesian and Japanese PR are separated?

Yes.