search

ant-design / antd-mobile-samples

antd-mobile samples
1.15k stars 1.09k forks source link

sorry,we don't have 'config/' folder name to modify when we use create-react-app... #30

Closed meetflyings closed 7 years ago

meetflyings commented 7 years ago

webpack.config.dev.js (path: node_modules/react-scripts/config);should i modify it?

paranoidjk commented 7 years ago

you may need to run npm run eject first.

afc163 commented 7 years ago

https://ant.design/docs/react/use-with-create-react-app

We don't recommend ejecting now.

paranoidjk commented 7 years ago

https://github.com/timarney/react-app-rewired#2-create-a-config-overridesjs-file-in-the-root-directory

@afc163 looks like atool-build usage, configuration file is a function, webpack config --> create-react-app-config --> react-app-rewired config, i am worried about the version upgrade issue in this way.

silentcloud commented 7 years ago

@afc163 Why？

afc163 commented 7 years ago

The eject config is changed when cra is upgraded, it is hard to maintain a documentation that always works.