ant-design / cssinjs

https://ant-design.github.io/cssinjs
MIT License
235 stars 57 forks source link

fix: style should not be removed when remounted #160

Closed MadCcc closed 7 months ago

MadCcc commented 7 months ago

修复组件重新 mount 时,插入的样式会被延后删除的问题。

事件顺序:

  1. 组件卸载,将清除样式的任务放进下一次的 effect cleanup 中
  2. 组件重新 mount,添加样式,发现 dom 中已存在,所以不会重复添加
  3. 触发 effect cleanup,删除了已有样式,导致样式丢失。

解法: 注销样式前实时判断 cache 中是否存在。

github-actions[bot] commented 7 months ago

🎊 PR Preview 5a04166feca8f7d39beb3cbb9250b3ada9a718ff has been successfully built and deployed to https://ant-design-cssinjs-preview-pr-160.surge.sh

:clock1: Build time: 102.753s

🤖 By surge-preview

afc163 commented 7 months ago

解决啥原始问题?

MadCcc commented 7 months ago

解决啥原始问题?

更新了 PR Body