search

ant-design / pro-components

🏆 Use Ant Design like a Pro!
https://pro-components.antdigital.dev
MIT License
4.33k stars 1.37k forks source link

🧐[问题] 为什么 SettingDrawer 要通过查询参数配置呢？ #2016

Closed yunsii closed 3 years ago

yunsii commented 3 years ago

🧐 问题描述

如果在生产环境也要使用的话，那会导致 url 很长，给人的感觉很不好 😂 比如：

https://theprimone.top/ant-design-pro-plus/route-tabs-demo/result?id=&query=yes&primaryColor=%231890ff&autoHideHeader=false&fixSiderbar=true&colorWeak=false&pwa=false&routeTabsMode=route&fixedRouteTabs=false&reloadTab=true

💻 示例代码

考虑通过 React.Context 解决？

github-actions[bot] commented 3 years ago

Issue Robot generation

以下的issue可能会帮助到你 ：

chenshuai2144 commented 3 years ago

为了方便你copy给别人看样子。主要是为了方便设计师

yunsii commented 3 years ago

@chenshuai2144 如果生产环境我也要用这个组件来配置呢？那这样 url 还是不合理吧，还是说自己再实现一个配置功能？

chenshuai2144 commented 3 years ago

可以来个pr 关掉这个功能

获取 Outlook for Androidhttps://aka.ms/ghei36

From: 云深 notifications@github.com Sent: Thursday, February 25, 2021 10:21:49 PM To: ant-design/pro-components pro-components@noreply.github.com Cc: 陈帅 qixian.cs@outlook.com; Mention mention@noreply.github.com Subject: Re: [ant-design/pro-components] 🧐[问题] 为什么 SettingDrawer 要通过查询参数配置呢？ (#2016)

@chenshuai2144https://apac01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fchenshuai2144&data=04%7C01%7C%7Ccdc41e1db0a44a8090cb08d8d998b14b%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637498597118308703%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=GEATaxoE22AYt90Dvm71Li2TRVRoKTkZYr4D5mDHZLU%3D&reserved=0 如果生产环境我也要用这个组件来配置呢？那这样 url 还是不合理吧，还是说自己再实现一个配置功能？

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://apac01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fant-design%2Fpro-components%2Fissues%2F2016%23issuecomment-785930096&data=04%7C01%7C%7Ccdc41e1db0a44a8090cb08d8d998b14b%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637498597118318656%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=EkH3Qw0D8skB07qVqldn2m2ldcQ%2FP2J2AwY22kVH4NA%3D&reserved=0, or unsubscribehttps://apac01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAB6OWKFXETFBUKYGX6DJ4UTTAZMH3ANCNFSM4YGQU7XA&data=04%7C01%7C%7Ccdc41e1db0a44a8090cb08d8d998b14b%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637498597118318656%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=BpW5RMWcnmxOg03DGYxkC62ynZH6VnmAdWoWDRTYoII%3D&reserved=0.

yunsii commented 3 years ago

好的，那我试试

github-actions[bot] commented 3 years ago

Hello @theprimone. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. We appreciate your effort in advance and looking forward to your contribution!

你好 @theprimone，我们完全同意你的提议/反馈，欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请务必提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等，并确保 CI 通过，我们会尽快进行 Review，提前感谢和期待您的贡献。

giphy