search

ant-design / static-style-extract

MIT License
27 stars 5 forks source link

Antd version needs to match project antd version #10

Closed hannesj closed 1 year ago

hannesj commented 1 year ago

Currently the package specifies the antd version in the dependencies as ^5.3.0. When using yarn as package manager, when upgrading the antd dependency in a project, yarn wants to keep the version previously installed for each dependency and copies the previously installed version to node_modules inside @ant-design/static-style-extract directory in node_modules. This causes two different versions of antd to be installed, which makes the themes not work when extracting the css. Instead of the current way of specifying the antd dependency, it would be better to put it inside peerDependencies, as is suggested in the documentation.

iglv commented 1 year ago

We're looking forward to that, too.

kiner-tang commented 1 year ago

Thanks for the feedback. Let me follow up on this.

kiner-tang commented 1 year ago

Completed in @ant-design/static-style-extract@1.0.2