search

ant-media / conference-call-application

Conference Call Application over Ant Media Server
20 stars 14 forks source link

Fix/circle recording issues #325

Closed mustafaboleken closed 2 months ago

mustafaboleken commented 2 months ago

https://github.com/ant-media/conference-call-application/issues/313 https://github.com/ant-media/conference-call-application/issues/322

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 50.77%. Comparing base (191c5dc) to head (713f1f2). Report is 35 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #325 +/- ## ========================================== + Coverage 49.89% 50.77% +0.87% ========================================== Files 21 21 Lines 1860 1881 +21 Branches 408 412 +4 ========================================== + Hits 928 955 +27 + Misses 828 824 -4 + Partials 104 102 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mekya commented 2 months ago

Hi @mustafaboleken,

I could not find the test codes. Where are they?

mustafaboleken commented 2 months ago

Hi @mekya

I tried to write test code but couldn't find a proper way right now, still working on it. The issue is even the issue that I fixed occurred, there is no place to check if video is playable or not. I will let you know whenever it's ready.