search

antangelo / xdvdfs

Original Xbox DVD Filesystem library and management tool
https://xiso.antangelo.com/
MIT License
77 stars 8 forks source link

Add support for Xbox 360 XDVDFS images #94

Closed astarivi closed 2 months ago

astarivi commented 2 months ago

Adds XGD2 and XGD3 offsets to support Xbox 360 XDVDFS image unpacking. So far, XGD2 and XGD3 support has been tested with the following Redump verified dumps, from my own collection:

XGD2:

XGD3:

All images from the JAP, or WORLD region; all images produced a valid MD5 repack.

More testing is needed with known "problematic" images, like games with long paths, long filenames, .xex files at the end of the image, etc. Sadly, I don't happen to own any game that fits the description.

antangelo commented 2 months ago

If this is all that is needed to support Xbox 360 images then it seems reasonable to me. I do not have any 360 discs or hardware, so I don't really have any ability or interest to test or support this myself. Are you willing to support/field any issues that arise from having this functionality?

I don't know if there are any differences between the filesystem structure for Xbox 360 images as opposed to ones on the OG Xbox. You can add additional test cases to the suite for long paths or certain filenames if they are appropriate. The suite doesn't currently have a way to replicate image binary quirks, it just relies on xdvdfs' own packing mechanism to generate the structure to avoid storing binary blobs in the repo.

astarivi commented 2 months ago

I have all that is needed to test this feature, and I fully intend to support this feature.

About the 360's XDVDFS version, I also do not know if there are any differences; documentation on this is lacking, although all images that I tested have created valid, fully playable results.

Other XISO tools seem to treat the FS on 360 images the same as regular OG Xbox images. I say it is safe to assume them as compatible filesystems for now.

I believe current testing cases are more than sufficient, if treating both Xbox and Xbox 360 images as the same filesystem. I tested the cases I previously mentioned, and there were no issues, either.

Nevertheless, I am not against adding more testing cases specialized on Xbox 360 images, but I believe it is preferable to wait for actual problems to emerge with Xbox 360 support to start testing for them.

antangelo commented 2 months ago

Sounds good to me. Thanks!