antarctica / PolarRoute

Long-distance maritime polar route planning, taking into account complex changing environmental conditions.

https://antarctica.github.io/PolarRoute/

MIT License

17 stars 3 forks source link

Reformat geojson output to remove infs #209

Closed gecoombs closed 1 year ago

gecoombs commented 1 year ago

Date: 13/07/23 Version Number: 0.2.14 -> 0.2.15

Description of change

Change the function that exports a mesh to geojson to average list values and remove infs and replace then with null values.

Fixes

https://github.com/antarctica/SDADT-project/issues/147

Testing

[x] My changes result in all required regression tests passing without the need to update test files.

Test dump:

pytest_dump.txt

Changed: polar_route/mesh_generation/environment_mesh.py

Checklist

[x] My code follows pep8 style guidelines.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have updated the documentation of the codebase where required.
[x] My changes generate no new warnings.
[x] My PR has been made to the 0.2.x branch (DO NOT SUBMIT A PR TO MAIN)

SamuelHall700 commented 1 year ago

High-jacking the PR to remove a print state I'd left in the export_mesh cli. Looks good!

gecoombs commented 1 year ago

Good spot for the print statement :slightly_smiling_face: