antarctica / PolarRoute

Long-distance maritime polar route planning, taking into account complex changing environmental conditions.
MIT License
15 stars 3 forks source link

Bug Fixing - Waypoints on boundary of mesh edge #254

Closed Ulvetanna closed 4 months ago

Ulvetanna commented 4 months ago

…the point is still included.

PolarRoute Pull Request Template

Date: 22/Feb/2024 Version Number: '0.3.10'

Description of change

There is currently an issue where if a waypoint is on the edge of the mesh then the waypoint is classed as outside the domain.

Fixes # (issue)

I have made the change that the boundary is included as inside the domain

Testing

To ensure that the functionality of the PolarRoute codebase remains consistent throughout the development cycle a testing strategy has been developed, which can be viewed in the document test/testing_strategy.md. This includes a collection of test files which should be run according to which part of the codebase has been altered in a pull request. Please consult the testing strategy to determine which tests need to be run.

list which files have been altered and include a pytest.txt file for each of the tests required to be run

The files which have been changed during this PR can be listed using the command

git diff --name-only 0.3.x

include pytest.txt file showing which tests fail.
include reasoning as to why your changes cause these tests to fail.

Should these changes be valid, relevant test files should be updated.
include pytest.txt file of test passing after test files have been updated.

Checklist

Ulvetanna commented 4 months ago

RunableExample.zip unit_test.log

Here is a runnable example that for the path construction will not work on the current version of the codebase, but does after this fix. Run by bash run.sh