Tests that need to be written

antarctica / PolarRoute

Long-distance maritime polar route planning, taking into account complex changing environmental conditions.

MIT License

15 stars 3 forks source link

Tests that need to be written #263

Open hjabbot opened 3 months ago

hjabbot commented 3 months ago

The existing tests are old an need updating. This issue is meant to be a place to host a list of tests we should implement. We should also prune through the existing tests to see what's necessary or redundant.

We can also create a bash script to automatically figure out what tests to run, and then run them, without us having to figure it out manually

hjabbot commented 3 months ago

Waypoints

[ ] Waypoint on boundary
[x] Waypoint in large cellbox

hjabbot commented 3 months ago

Crossing points

[x] Checking that crossing point between adjacent cells is correct for each neighbour case

hjabbot commented 3 months ago

Routes

[ ] Cells near inaccessible cells should be small enough to navigate through without being unfairly penalised

gecoombs commented 3 months ago

Unit tests for Dijkstra in open water:

[x] Change of latitude: (0, ±20, ±40, ±80)
[x] Change of longitude
[x] Change of cell size
[x] Offset cells
[x] Offset waypoint locations
[x] Crossing equator
[x] Crossing anti-meridian
[x] Consider scalar fields
[x] Different split depths
[x] Consider vector fields
[x] Split cell corner case
[x] Split cells scalar/vector fields

Additional regression tests:

[ ] Long path east to west

gecoombs commented 2 months ago

Smoothed path tests:

[x] Waypoints close to cell boundary
[x] Corner to corner
[x] Constant latitude at equator and ±80
[ ] Split cells
[ ] Offset waypoint locations

Ulvetanna commented 2 months ago

I think it's worth also considering changing waypoint start and end locations to test if the first and last leg of the journey is correct. This will also help with the inclusion of the Dijkstra refactor

gecoombs commented 2 months ago

Good point :slightly_smiling_face: I have actually already added a couple of these for the Dijkstra case but they're not listed above, I'll add them there and to the smoothed test list.