antarctica / PolarRoute

Long-distance maritime polar route planning, taking into account complex changing environmental conditions.
https://antarctica.github.io/PolarRoute/
MIT License
17 stars 3 forks source link

Routing splitting waypoints #276

Closed Ulvetanna closed 5 months ago

Ulvetanna commented 7 months ago

PolarRoute Pull Request Template

Description of change

Adding in the functionality to split the mesh aground the waypoints locations to reduce the discrepancy for the route construction. This can now be toggled by an optional parameter within the config file

Fixes # (issue)

275

Testing

To ensure that the functionality of the PolarRoute codebase remains consistent throughout the development cycle a testing strategy has been developed, which can be viewed in the document test/testing_strategy.md. This includes a collection of test files which should be run according to which part of the codebase has been altered in a pull request. Please consult the testing strategy to determine which tests need to be run.

list which files have been altered and include a pytest.txt file for each of the tests required to be run

The files which have been changed during this PR can be listed using the command

git diff --name-only 0.4.x

include pytest.txt file showing which tests fail.
include reasoning as to why your changes cause these tests to fail.

Should these changes be valid, relevant test files should be updated.
include pytest.txt file of test passing after test files have been updated.

Checklist

Ulvetanna commented 7 months ago

Please find attached the testing logs for test_routes_dijkstra.py and test_routes_smoothed.py.

dijkstra_test.log smoothed_test.log

Currently it's failing on the smoothed routes and I will investigate further. This could be due to the changes in a hotfix from a while back where the blocking condition changed. I will investigate further

Ulvetanna commented 6 months ago

Requirements needed to add:

@SamuelHall700 @hjabbot @gecoombs I will drop a message once all these have been completed on this pull request :)

Ulvetanna commented 6 months ago

Updated the regression tests with the corrected blocking conditions. The blocking condition has a weird effect on the fuel optimised path. This needs to be investigated further in a later pull request.