search

antarctica / PolarRoute

Long-distance maritime polar route planning, taking into account complex changing environmental conditions.
MIT License
15 stars 3 forks source link

Regression tests are currently failing on main #277

Open hjabbot opened 2 months ago

hjabbot commented 2 months ago

Since the recent hotfix, the gaussian_random_field smoothed regression test set is failing.

It is unclear as of yet whether this failing test is because the path is better (and tests should be updated) or worse (where it should be patched).

hjabbot commented 2 months ago

An example of the path differences between old and new

Old route: Image

New route: Image

SamuelHall700 commented 2 months ago

@Ulvetanna are these new changes correct? If so, we need to update the test examples

Ulvetanna commented 2 months ago

@SamuelHall700 going to address this and update the changes in the latest pull request. The new example shown by hjabbot is the correct one, and the regression test will will be updated to allow for this.