antarctica / PolarRoute

Long-distance maritime polar route planning, taking into account complex changing environmental conditions.
https://antarctica.github.io/PolarRoute/
MIT License
17 stars 3 forks source link

Bug Fixing - Path Smoothing failures #308

Closed Ulvetanna closed 3 weeks ago

Ulvetanna commented 3 weeks ago

PolarRoute Pull Request Template

Date:
Version Number:

Description of change

Fixing bug raised in #303

Fixed bug where dijkstra was called multiple times for the same graph

Fixed bug where early stopping criterion was not present in the codebase

Fixes # (issue)

Testing

To ensure that the functionality of the PolarRoute codebase remains consistent throughout the development cycle a testing strategy has been developed, which can be viewed in the document test/testing_strategy.md. This includes a collection of test files which should be run according to which part of the codebase has been altered in a pull request. Please consult the testing strategy to determine which tests need to be run.

list which files have been altered and include a pytest.txt file for each of the tests required to be run

The files which have been changed during this PR can be listed using the command

git diff --name-only 1.1.x

include pytest.txt file showing which tests fail.
include reasoning as to why your changes cause these tests to fail.

Should these changes be valid, relevant test files should be updated.
include pytest.txt file of test passing after test files have been updated.

Checklist

Ulvetanna commented 3 weeks ago

regression_tests.txt

Adding in regression tests