search

antares-sql / antares

A modern, fast and productivity driven SQL client with a focus in UX
https://antares-sql.app
MIT License
1.6k stars 111 forks source link

chore: upgrade electron #805

Closed mangas closed 1 month ago

mangas commented 1 month ago

Would be great to upgrade to a newer version of electron so we can use the following on wayland

https://www.electronjs.org/docs/latest/api/environment-variables#electron_ozone_platform_hint-linux

mangas commented 1 month ago

I don't really know my way around the repo so if there's something missing test or upgrade wise let me know

Fabio286 commented 1 month ago

There is a need to test if the whole build system is working properly and if there are breaking changes. I'll do some testing but there shouldn't be any major problems with the update though.

mangas commented 1 month ago

Thanks @Fabio286 let me know if I can help with anything

Fabio286 commented 1 month ago

I tried your PR and i have some issues running Antares. I have to go deeper and check electron breaking changes after version 26.

Fabio286 commented 1 month ago

Ok, issues disappeared updating @electron/remote to latest.

Fabio286 commented 1 month ago

@all-contributors add @mangas for code

allcontributors[bot] commented 1 month ago

@Fabio286

I've put up a pull request to add @mangas! :tada:

mangas commented 1 month ago

awesome! thanks for checking :raised_hands:

@Fabio286 do you mind tagging a release so we can use this on flathub?