antchfx / xmlquery

xmlquery is Golang XPath package for XML query.
https://github.com/antchfx/xpath
MIT License
444 stars 89 forks source link

Add SetAttr and RemoveAttr functions #90

Closed tchen closed 2 years ago

tchen commented 2 years ago

Allow editing and removal of attributes.

zhengchun commented 2 years ago

Hello, thanks for contribute. The RemoveAttr() may be better than UnsetAttr(), people knowns what it does from its name. what do you think?

tchen commented 2 years ago

Sounds reasonable. I'll make the change.

tchen commented 2 years ago

@zhengchun Please review again. Thanks!